-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7906 delete extra space from the end of an API success message. #7907
#7906 delete extra space from the end of an API success message. #7907
Conversation
I extended a test to cover the success message content. |
@pkiraly I don't think this is needed (we already check the status code). The actual message isn't critical, just success of failure. This is actually a great example, had the test already contained this assert, then it would have failed for the removing of a space - having that fail adds no (or at least little) value. |
|
@pkiraly yes, let's remove - alternatively, if you think it's important output, we should return it as part of a more structured json and not as just part of the message itself. (but that could also be out of scope for now) |
@scolapasta done |
This PR was developed by Göttingen eResearch Alliance, Germany, and funded by SSHOC, "Social Sciences and Humanities Open Cloud". SSHOC has received funding from the European Union’s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782. |
What this PR does / why we need it: When an administrator delete a user, s/he receives a JSON message containing a string: "AuthenticatedUser [identifier] deleted. ". At the end of this message there is an unwanted extra space.
Which issue(s) this PR closes:
Closes #7906
Special notes for your reviewer: no
Suggestions on how to test this: no
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: no