Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md in an attempt to appeal to inexperienced cont… #3882

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Updated CONTRIBUTING.md in an attempt to appeal to inexperienced cont… #3882

merged 2 commits into from
Jun 5, 2017

Conversation

HedgeMage
Copy link
Contributor

…ributors.

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

  • connects to [#issue number]: [issue title]

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.038% when pulling 426cf45 on HedgeMage:develop into 9ff48e0 on IQSS:develop.

@pdurbin
Copy link
Member

pdurbin commented Jun 4, 2017

@HedgeMage thanks for the pull request.

Over at https://irclogs.jackgrigg.com/irc.freenode.net/openhatch/2017-06-04#i_4123313 @HedgeMage was saying that potential contributors "look at a doc about how to do things, and it completely skips what they want to know (which we don't accept as a concept): How do I get permission to participate?"

I asked her to take a swing at improving our CONTRIBUTING.md file. I'll move this over to code review at https://waffle.io/IQSS/dataverse

@coveralls
Copy link

Coverage Status

Coverage remained the same at 10.038% when pulling bd3cd09 on HedgeMage:develop into 9ff48e0 on IQSS:develop.

@dlmurphy
Copy link
Contributor

dlmurphy commented Jun 5, 2017

Just made a few small edits for phrasing, looks great! It's ready for @kcondon's review.

@dlmurphy dlmurphy removed their assignment Jun 5, 2017
@kcondon kcondon merged commit f9cdceb into IQSS:develop Jun 5, 2017
@kcondon kcondon self-assigned this Jun 5, 2017
@kcondon kcondon removed the Status: QA label Jun 5, 2017
@pdurbin pdurbin added this to the 4.7 - Dashboard and Customization milestone Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants