Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dirindexdoes not support web browsing #7823

Closed
mankoff opened this issue Apr 24, 2021 · 5 comments · Fixed by #7894
Closed

dirindexdoes not support web browsing #7823

mankoff opened this issue Apr 24, 2021 · 5 comments · Fixed by #7894

Comments

@mankoff
Copy link
Contributor

mankoff commented Apr 24, 2021

Follow-up on #7084 because that has remained closed even after an issue was raised.

The implementation discussion (and a logical behavior) supports a web browser access to the dirindex, not just wget. See for example #7084 (comment)

But the current implementation does not support a web browser. When I go to https://demo.dataverse.org/api/datasets/24/dirindex I'm given a ".index" to download in firefox, not something that I can view in my browser.

Cc: @landreev
@djbrooke
Copy link
Contributor

Thanks @mankoff, we'll take a look. Right now we're focusing on some performance issues but we should be able to get back to this soon. From a process perspective, we don't usually reopen old issues, so a new issue is great. Thanks!

@djbrooke
Copy link
Contributor

djbrooke commented May 5, 2021

  • likely related to setting the mimetype incorrectly, need to revisit contentdisposition

@djbrooke djbrooke added the Small label May 5, 2021
@pdurbin pdurbin self-assigned this May 19, 2021
pdurbin added a commit that referenced this issue May 21, 2021
@pdurbin
support web browsing of dirindex #7823
b264970 
Previously, .index.html files were being downloaded as attachments.
pdurbin added a commit that referenced this issue May 21, 2021
@pdurbin
make dirindex images appear in docs #7823
86b70b7
@pdurbin pdurbin mentioned this issue May 21, 2021
Merged
@pdurbin
Copy link
Member

pdurbin commented May 21, 2021

@mankoff et al., I just made pull request #7894 to fix this.

@pdurbin pdurbin removed their assignment May 21, 2021
@mankoff
Copy link
Contributor Author

mankoff commented May 21, 2021

I'll test it on demo.dataverse.org as soon as I can...

@pdurbin
Copy link
Member

pdurbin commented May 28, 2021

@mankoff sounds good. It was just merged. That demo server will be updated after we put out a release (like usual).

@mankoff mankoff mentioned this issue Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7823 dirindex web browsing and docs IQSS/dataverse
3 participants
@pdurbin @mankoff @djbrooke