Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guides - Developers vs. Developers' #2864

Closed
mheppler opened this issue Jan 13, 2016 · 3 comments
Closed

Guides - Developers vs. Developers' #2864

mheppler opened this issue Jan 13, 2016 · 3 comments
Assignees
@kcondon
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
4.2.3

Comments

@mheppler
Copy link
Contributor

The use of Developers vs. Developers' for the guides is inconsistent across the application.

Since "User" and "Installation" are singular, I suggest we put this debate to rest once and for all by changing all instances and references of the guide that is to be used by a developer to the "Developer Guide".
@mheppler mheppler added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Critical labels Jan 13, 2016
@pdurbin
Copy link
Member

pdurbin commented Jan 13, 2016

👍 good idea, @mheppler

I'm on board with changing it to "Developer Guide" (singular). The only place we won't change is the URL which will still have "developers" ( http://guides.dataverse.org/en/latest/developers ) but that's fine.

@mheppler mheppler changed the title Guide - Developers vs. Developers' Guides - Developers vs. Developers' Jan 13, 2016
mheppler added a commit that referenced this issue Jan 13, 2016
@mheppler
Fixed all references to the "Developer Guide" to be consistent across…
72421fc 
… the entire app. [ref #2864]
pdurbin added a commit that referenced this issue Jan 14, 2016
@pdurbin
Merge branch '2864-2866-guides' into 4.2.3 #2864 #2866
6fe7c3a
@pdurbin
Copy link
Member

pdurbin commented Jan 14, 2016

I just merged the fix into the 4.2.3 branch (will set the milestone to this) in 6fe7c3a since this looks fine on my laptop ("Developer Guide" singular):

screen shot 2016-01-14 at 4 25 06 pm

Passing to QA. @mheppler if you have any particular testing instructions, please comment.

@pdurbin pdurbin added this to the 4.2.3 milestone Jan 14, 2016
@pdurbin pdurbin assigned kcondon and unassigned mheppler Jan 14, 2016
@kcondon
Copy link
Contributor

kcondon commented Jan 14, 2016

Closing

@kcondon kcondon closed this as completed Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
4.2.3
Development

No branches or pull requests
4 participants
@pdurbin @mercecrosas @mheppler @kcondon