Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(road2config): default value for pop to avoid exception #51

Merged
merged 1 commit into from
Apr 7, 2023
Merged

fix(road2config): default value for pop to avoid exception #51

merged 1 commit into from
Apr 7, 2023

Conversation

jmkerloch
Copy link
Contributor

When creating road2config, some attributes are removed with pop. Theses attributes are not needed for road2 and should not raise an exception if not defined in the input .json

@jmkerloch jmkerloch added this to the sprint4 milestone Apr 7, 2023
@jmkerloch jmkerloch self-assigned this Apr 7, 2023
@jmkerloch jmkerloch added the bug Something isn't working label Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1016 377 37% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
r2gg/_main.py 29% 🟢
TOTAL 29% 🟢

updated for commit: 6c05c8e by action🐍

@jmkerloch jmkerloch requested a review from benoitblanc April 7, 2023 07:59
@jmkerloch jmkerloch merged commit ef5940d into develop Apr 7, 2023
@jmkerloch jmkerloch deleted the fix/pop_value_in_road2_config branch April 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

@benoitblanc benoitblanc Awaiting requested review from benoitblanc

Assignees

@jmkerloch jmkerloch

Labels
bug Something isn't working
Projects
Road2 backlog
Status: ✅ Done
Milestone
sprint4
Development

Successfully merging this pull request may close these issues.
2 participants
@jmkerloch @Guts