Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing test failure due to new pint release #786

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fixing test failure due to new pint release #786

merged 2 commits into from
Apr 4, 2022
+8 −8

Conversation

andrewlee94
Copy link
Member

Fixes #784

Summary/Motivation:

A recent new release of pint broke some string comparisons in our tests.

Changes proposed in this PR:

  • Fix string comparison to build expected expression and cast to string rather than hard code expected string.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Apr 4, 2022
@andrewlee94 andrewlee94 changed the title Fixing bug doe to new pint release Fixing test failure due to new pint release Apr 4, 2022
@andrewlee94 andrewlee94 added bug Something isn't working Priority:High High Priority Issue or PR testing Issues dealing with testing of code dependencies Pull requests that update a dependency file labels Apr 4, 2022
@andrewlee94 andrewlee94 enabled auto-merge (squash) April 4, 2022 20:49
ksbeattie
ksbeattie approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #786 (9f31456) into main (f6e17d7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   67.12%   67.12%           
=======================================
  Files         528      528           
  Lines       60041    60041           
  Branches    10982    10982           
=======================================
+ Hits        40302    40304    +2     
+ Misses      17695    17694    -1     
+ Partials     2044     2043    -1
Impacted Files Coverage Δ
idaes/surrogate/pysmo/kriging.py 68.19% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7062751...9f31456. Read the comment docs.

@andrewlee94 andrewlee94 merged commit cade442 into IDAES:main Apr 4, 2022
@andrewlee94 andrewlee94 deleted the issue_784 branch April 5, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie

@eslickj eslickj

@lbianchi-lbl lbianchi-lbl

Assignees

@andrewlee94 andrewlee94

Labels
bug Something isn't working dependencies Pull requests that update a dependency file Priority:High High Priority Issue or PR testing Issues dealing with testing of code
Projects
No open projects
2022 May 2.0.0a2 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing tests on Git
4 participants
@andrewlee94 @ksbeattie @eslickj @lbianchi-lbl