Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing scaling bug related to external functions with string arguments #1487

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Fixing scaling bug related to external functions with string arguments #1487

merged 2 commits into from
Sep 10, 2024

Conversation

andrewlee94
Copy link
Member

Related to #1355

Summary/Motivation:

The discussion in #1355 brought up an edge case where the nominal expression walker was failing due to encountering an external function with a string argument.

Changes proposed in this PR:

  • Check for string arguments when evaluating external function nodes
  • Adds test for this edge case

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 added bug Something isn't working Priority:Normal Normal Priority Issue or PR core Issues dealing with core modeling components labels Sep 6, 2024
@andrewlee94 andrewlee94 self-assigned this Sep 6, 2024
@andrewlee94 andrewlee94 added the user request Requests from external users label Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.84%. Comparing base (6ffcde7) to head (edcfe2a).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1487      +/-   ##
==========================================
- Coverage   76.84%   76.84%   -0.01%     
==========================================
  Files         376      376              
  Lines       61087    61091       +4     
  Branches    13504    13505       +1     
==========================================
+ Hits        46942    46945       +3     
- Misses      11763    11766       +3     
+ Partials     2382     2380       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dallan-keylogic
dallan-keylogic approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlee94 andrewlee94 enabled auto-merge (squash) September 10, 2024 18:22
@andrewlee94 andrewlee94 merged commit b6be02e into IDAES:main Sep 10, 2024
38 of 58 checks passed
@andrewlee94 andrewlee94 deleted the old_scaling_bug branch September 10, 2024 19:36
lbianchi-lbl pushed a commit that referenced this pull request Oct 1, 2024
@lbianchi-lbl
Fixing bug related to external functions with string arguments (#1487)
bf1ae3c 
(cherry picked from commit b6be02e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallan-keylogic dallan-keylogic dallan-keylogic approved these changes

@bpaul4 bpaul4 bpaul4 approved these changes

@mrmundt mrmundt mrmundt approved these changes

@jsiirola jsiirola Awaiting requested review from jsiirola

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl lbianchi-lbl is a code owner

Assignees

@andrewlee94 andrewlee94

Labels
bug Something isn't working core Issues dealing with core modeling components Priority:Normal Normal Priority Issue or PR user request Requests from external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewlee94 @codecov-commenter @mrmundt @bpaul4 @dallan-keylogic