-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 release candidate #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangunter
approved these changes
Feb 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
eslickj
pushed a commit
that referenced
this pull request
Jan 30, 2021
Fix radian problem in drum model
andrewlee94
pushed a commit
that referenced
this pull request
Mar 11, 2021
updated moving bed and bubbling fluidized bed unit models and tests t…
Xinhe-Chen
pushed a commit
to Xinhe-Chen/idaes-pse
that referenced
this pull request
Jan 12, 2022
Clean up Estimator constructor
Xinhe-Chen
pushed a commit
to Xinhe-Chen/idaes-pse
that referenced
this pull request
Jan 12, 2022
Looks good! Merging now
Xinhe-Chen
pushed a commit
to Xinhe-Chen/idaes-pse
that referenced
this pull request
Jan 12, 2022
Generalize objects
eslickj
pushed a commit
that referenced
this pull request
Jan 15, 2022
Minor update to Petsc DAE code
bpaul4
added a commit
to bpaul4/idaes-pse
that referenced
this pull request
Aug 8, 2022
* Sphinx Documentation Build Issue (IDAES#890) * switch lang flag to 'en' * Flag formatting * Update path reference * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * Running black on the entire repo (IDAES#894) * Running black on the entire repo * Add pinned requirement for Black stable version * Add CI check to ensure code is Black-formatted Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> * Fix PySMO tests (IDAES#903) * Minor change to trigger tests * Added abs to tolerance check * Run black * Remove string comparison * Tighten tolerance * Fixed kriging test by removing variable dependence * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity Co-authored-by: Keith Beattie <ksbeattie@lbl.gov> Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> Co-authored-by: OOAmusat <47539353+OOAmusat@users.noreply.github.com> Co-authored-by: Daison2102 <32642037+Daison2102@users.noreply.github.com>
andrewlee94
pushed a commit
that referenced
this pull request
Oct 14, 2022
* updating power plant costing to new costing framework * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity * Fixing test issues, bringing in MEA_CCS code (#1) * Sphinx Documentation Build Issue (#890) * switch lang flag to 'en' * Flag formatting * Update path reference * updating power plant capcost and QGESS tests to run as expected * bring over MEA_CCS updates and tests * running black on costing/ directory * move custom dicts to new file * fix some spacing causing doc build errors * Replace method calls with UnitModelCostingBlocks * Running black on the entire repo (#894) * Running black on the entire repo * Add pinned requirement for Black stable version * Add CI check to ensure code is Black-formatted Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> * Fix PySMO tests (#903) * Minor change to trigger tests * Added abs to tolerance check * Run black * Remove string comparison * Tighten tolerance * Fixed kriging test by removing variable dependence * bring in report method updates * bring in more MEA CCS updates * Add check on total TPC * final formatting fixes * Update report method Adding cost of electricity and cost of capture to report method * Black reformatting * Update report method Fixing units of cost of electricity Co-authored-by: Keith Beattie <ksbeattie@lbl.gov> Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> Co-authored-by: OOAmusat <47539353+OOAmusat@users.noreply.github.com> Co-authored-by: Daison2102 <32642037+Daison2102@users.noreply.github.com> * costing updates * costing updates * improving generic variable O&M costs calculation * Updating currency and basis unit handling, other minor fixes * Zipping together costing dictionaries * Improvements from review comments * Updating tests for new changes * Updating author tags * Removing QGESS tests, updating NGCC tests, adding capcost tests, param unit fixes * Sort author list * General improvements and cost variable unit corrections * Removing deprecated default arguments * Addressing most review comments * Addressing more review comments * Testing and coverage improvements * Resolving pylint and directory reference issues * Separating power plant currency units * cleaning up comments * Final fixes from review comments * Add some checks to json regeneration test Co-authored-by: Miguel Zamarripa-Perez <zamarrim@ad.science> Co-authored-by: Daison2102 <32642037+Daison2102@users.noreply.github.com> Co-authored-by: Keith Beattie <ksbeattie@lbl.gov> Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> Co-authored-by: OOAmusat <47539353+OOAmusat@users.noreply.github.com>
avdudchenko
added a commit
to avdudchenko/idaes-pse
that referenced
this pull request
Nov 22, 2024
ksbeattie
added a commit
that referenced
this pull request
Dec 26, 2024
…tion (#1512) * first commit * typo fixes * Update model_statistics.py * updates to tests * moved where we count greybox var * add additonal functions to get grayboxblocks * initial addi tion of grayboxs stats to dignostic tools * Update test_model_statistics.py * udpate to diagonotsics * Update test_model_diagnostics.py consistency fix * Update model_diagnostics.py * addressign comments #1 * added errors for greybox * add exception tests * Update model_statistics.py * Update idaes/core/util/model_statistics.py Co-authored-by: Adam Atia <aatia@keylogic.com> --------- Co-authored-by: Adam Atia <aatia@keylogic.com> Co-authored-by: Keith Beattie <ksbeattie@lbl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.