Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: IBM/sarama
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.42.0
Choose a base ref
...
head repository: IBM/sarama
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.42.1
Choose a head ref
  • 7 commits
  • 14 files changed
  • 2 contributors

Commits on Nov 2, 2023

  1. chore(ci): bump ossf/scorecard-action from 2.1.2 to 2.3.1 (#2703)

    Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.3.1.
    - [Release notes](https://github.com/ossf/scorecard-action/releases)
    - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
    - [Commits](ossf/scorecard-action@e38b190...0864cf1)
    
    ---
    updated-dependencies:
    - dependency-name: ossf/scorecard-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 2, 2023
    Copy the full SHA
    4168f7c View commit details
  2. chore(ci): bump actions/dependency-review-action from 2.5.1 to 3.1.0 (#…

    …2702)
    
    Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 2.5.1 to 3.1.0.
    - [Release notes](https://github.com/actions/dependency-review-action/releases)
    - [Commits](actions/dependency-review-action@0efb1d1...6c5ccda)
    
    ---
    updated-dependencies:
    - dependency-name: actions/dependency-review-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 2, 2023
    Copy the full SHA
    a46917f View commit details

Commits on Nov 3, 2023

  1. fix: make fetchInitialOffset use correct protocol (#2705)

    The `fetchInitialOffset` func in offsetManager was hardcoded to send a
    Version 1 OffsetFetchRequest rather than sending the appropriate version
    based on the config KafkaVersion. As discussed in #2694 this meant that
    LeaderEpoch was always being decoded as the default value '0' (because
    it was only returned in Version >= 5 OffsetFetchRequest). However, other
    areas of the offsetManager code were sending the newer protocol
    versions, so for example the OffsetCommitRequest would include a leader
    epoch value of 0 rather than an accurate one.
    
    Correct this bug by sending the correct protocol version in
    fetchInitialOffset and also ensure we default to `-1` when we decode an
    OffsetFetchResponse of a Version < 5
    
    Fixes #2694
    
    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    dnwe authored Nov 3, 2023
    Copy the full SHA
    27710af View commit details

Commits on Nov 6, 2023

  1. chore(ci): bump actions/dependency-review-action from 3.1.0 to 3.1.1 (#…

    …2707)
    
    Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 3.1.0 to 3.1.1.
    - [Release notes](https://github.com/actions/dependency-review-action/releases)
    - [Commits](actions/dependency-review-action@6c5ccda...9f45b24)
    
    ---
    updated-dependencies:
    - dependency-name: actions/dependency-review-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Nov 6, 2023
    Copy the full SHA
    768496e View commit details
  2. chore(doc): add CODE_OF_CONDUCT.md

    Add GitHub's Contributor Covenant Code of Conduct template
    
    Signed-off-by: Dominic Evans <8060970+dnwe@users.noreply.github.com>
    dnwe authored Nov 6, 2023
    Copy the full SHA
    3364ff0 View commit details

Commits on Nov 7, 2023

  1. fix(config): relax ClientID validation after 1.0.0 (#2706)

    The original validation regex was based on the one that existed in the
    Java clients pre-1.0.0 but KIP-190 removed the client-side validation
    because instead the brokers were updated to be able to cope with any
    clientID and sanitize it before using it in metrics etc.
    
    We can do similar in Sarama and only do client-side validation when the
    user has specified a version number older than 1.0.0
    
    Fixes #2697
    
    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    dnwe authored Nov 7, 2023
    Copy the full SHA
    385b3b4 View commit details
  2. chore: update CHANGELOG.md to v1.42.1 (#2711)

    Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
    dnwe authored Nov 7, 2023
    Copy the full SHA
    d88a48a View commit details
Loading