Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for Linux ARM64 #5

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Build for Linux ARM64 #5

merged 4 commits into from
Feb 27, 2023

Conversation

Glavo
Copy link
Contributor

@Glavo Glavo commented Feb 25, 2023

Unfortunately, at present, GitHub Action does not provide Linux ARM64 server, so this PR only does the simplest repair.

@Glavo Glavo marked this pull request as draft February 25, 2023 20:16
@Glavo
Copy link
Contributor Author

Glavo commented Feb 25, 2023

I think I can use cross-compilation to build it, so I will temporarily convert it into a draft and open it after I finish.

@Glavo Glavo changed the title Fix common.py for linux arm64 platfrom Build for Linux ARM64 Feb 25, 2023
@Glavo
Copy link
Contributor Author

Glavo commented Feb 25, 2023

@tonsky

Completed, ready for review.

@Glavo Glavo marked this pull request as ready for review February 25, 2023 21:24
@tonsky tonsky merged commit 48b6820 into HumbleUI:master Feb 27, 2023
@tonsky
Copy link
Contributor

tonsky commented Feb 27, 2023

Thanks!

@Glavo Glavo deleted the linux-arm64 branch February 27, 2023 17:02
@Glavo
Copy link
Contributor Author

Glavo commented Feb 27, 2023

@tonsky

It seems that 82cfc18 has damaged CI. Can you fix it?

After it is fixed, I can try to update and test the GitHub Action configuration of Skija.

@tonsky
Copy link
Contributor

tonsky commented Feb 27, 2023

I think it’s going fine so far. It just aborted already existing versions (by design) and only builds arm for linux

@Glavo
Copy link
Contributor Author

Glavo commented Feb 27, 2023

I think it’s going fine so far. It just aborted already existing versions (by design) and only builds arm for linux

Well, I may have misunderstood the meaning of the failed state in GitHub Action.

@tonsky
Copy link
Contributor

tonsky commented Feb 27, 2023

Because I don’t rebuild Skia too often, I also tend to forget about it and get scared. Luckily, when I click to see what’s going on, I see that check-release fails and that means this version was already compiled. I wish there was an alternative way to gently cancel the task (is there?)

Screenshot 2023-02-27 at 18 29 26

@Glavo
Copy link
Contributor Author

Glavo commented Feb 27, 2023

Because I don’t rebuild Skia too often, I also tend to forget about it and get scared. Luckily, when I click to see what’s going on, I see that check-release fails and that means this version was already compiled. I wish there was an alternative way to gently cancel the task (is there?)

Screenshot 2023-02-27 at 18 29 26

Maybe you can write environment variables through check_release.py and check environment variables in all subsequent operations? I don't know if there is a simpler way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants