Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HistoryManager can cause a significant increase in memory usage. #203

Closed
xavier711 opened this issue Jun 13, 2023 · 1 comment
Closed

HistoryManager can cause a significant increase in memory usage. #203

xavier711 opened this issue Jun 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@xavier711
Copy link
Contributor

version

latest

Link to minimal reproduction

No response

Steps to reproduce

Enter text continuously and see the increasing memory through the Perfermace Monitor in Chrome Dev Tools.

What is expected?

Should't use so much memory.

What is actually happening?

snipaste

System Info

No response

Any additional comments?

HistoryManager can cause a significant increase in memory usage.
The more data there is, the more noticeable the growth, eventually leading to a browser crash.
Can local storage be used to handle data for the HistoryManager?
@Hufe921 Hufe921 added the enhancement New feature or request label Jun 13, 2023
@Hufe921
Copy link
Owner

Hufe921 commented Jun 13, 2023

editor max record count memory growth rate debounce
canvas-editor 1000 fast no
kdocs 100 stable yes（instable）
tencent - fast yes
google - stable yes

Optimizing undo/redo memory usage by comparing different editors, the first step to consider is debouncing

Hufe921 added a commit that referenced this issue Jun 16, 2023
@Hufe921
feat: add history max record option #203
c467505
@Hufe921 Hufe921 closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hufe921 @xavier711