boost: fix arm64 build #59257
Closed
boost: fix arm64 build #59257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I'm hoping it will fix an issue for us, but I don't own a Mac, so I can't help really. |
|
As the patch has been applied upstream, I pushed a slightly updated formula, which pulls in the patch from the boostorg/build repository. |
|
The failed CI test seems to result from a conflict between miniupnpc and wownero, which apparently includes and installs its own copy of miniupnpc. So the The CI test for the first iteration of this PR failed because of a similar issue: a conflict between eigen and another formula which included its own copy of eigen. I don't really know how to proceed here. Any help is appreciated. |
This was referenced Aug 30, 2020
BrewTestBot
pushed a commit
that referenced
this pull request
Aug 31, 2020
Add a `conflicts_with` directive to indicate that the newly-added `wownero` formula [1] also installs a `libminiupnpc.a` library. This currently blocks CI on PR #59257 [2]. To get this out of the way quickly, use `conflicts_with` for now instead of making `miniupnpc` a dependency of `wownero`. [1]: #59687 [2]: #59257 Closes #60391. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
BrewTestBot
pushed a commit
that referenced
this pull request
Aug 31, 2020
Add a `conflicts_with` directive to indicate that both this formula and `miniupnpc` install a `libminiupnpc.a` library. This currently blocks CI on PR #59257 [1]. To get this out of the way quickly, use `conflicts_with` for now instead of making `miniupnpc` a dependency of `wownero`. [1]: #59257 Closes #60392. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Patch Boost build system, so that it does inject '-arch arm64' instead of '-arch arm'. This patch is already applied upstream.
|
Force-pushed to (hopefully) let CI know that the issues with the other formulae are fixed. |
claui
approved these changes
Sep 1, 2020
9 tasks
|
Many thanks for helping me here! |
|
🤖 A scheduled task has triggered a merge. |
Thank you @aumuell for your contribution! You rock 🍻 |
5 tasks
andysan
added a commit
to andysan/homebrew-core
that referenced
this pull request
Jan 4, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR Homebrew#59257 that fixes the main boost package. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
andysan
added a commit
to andysan/homebrew-core
that referenced
this pull request
Jan 4, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR Homebrew#59257 that fixes the main boost package. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
andysan
added a commit
to andysan/homebrew-core
that referenced
this pull request
Jan 4, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR Homebrew#59257 that fixes the main boost package. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
BrewTestBot
pushed a commit
that referenced
this pull request
Jan 5, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR #59257 that fixes the main boost package. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
BrewTestBot
pushed a commit
that referenced
this pull request
Jan 5, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR #59257 that fixes the main boost package. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk>
BrewTestBot
pushed a commit
that referenced
this pull request
Jan 5, 2021
Patch Boost's build system to build cleanly on Apple silicon. This is a port of PR #59257 that fixes the main boost package. Closes #68272. Signed-off-by: Andreas Sandberg <andreas@sandberg.uk> Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch Boost build system, so that it does inject '-arch arm64' instead
of '-arch arm'. This patch is already submitted to Boost: boostorg/build#642
This fixes the boost problem mentioned here: Homebrew/brew#7857
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?