php: use brewed gd & pcre2, reorganise dependencies #58832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
SeekingMeaning
added
11
|
DNM? |
|
Please apply this to the versioned formula as well then. |
|
PHP 7.2 and 7.3 is less trivial and require backporting some patches. I'll have a look.
While it would be nice to see if this fixes things on Apple Silicon, I ultimately would still be merging this PR anyway since we should prefer brewed libraries over bundled ones. |
If it's not doable we can just skip it. Just wanted to make sure it was considered |
mistydemeo
approved these changes
Jul 30, 2020
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?gdandpcre2over bundled versions.pcre2formula.gdmeans thatfreetype,jpeg,libpngandwebpare no longer direct dependencies (but are dependencies ofgd).krb5dependency explicit (was pulled bylibpqand implicitly linked instead of the system version).libedit.pcto Homebrew/brew.