Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krb5: add a fix for broken configure test #58191

Merged
merged 1 commit into from
Jul 19, 2020
Merged

krb5: add a fix for broken configure test #58191

merged 1 commit into from
Jul 19, 2020

Conversation

mistydemeo
Copy link
Member

@mistydemeo mistydemeo commented Jul 18, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This fixes krb5 on macOS 11, both ARM and x86_64. It turns out that clang's new pickiness about calling functions without their header definitions broke this test. The test is actually testing destructor attributes, and for convenience is using the C unlink function. That is defined in unistd.h, but the configure test doesn't #include this header.

I'll be submitting an upstream fix as well, but this inreplace fix gets us going.

@mistydemeo mistydemeo added the 11 Big Sur is specifically affected label Jul 18, 2020
@claui claui mentioned this pull request Jul 19, 2020
Closed
9 tasks
claui
claui reviewed Jul 19, 2020
View reviewed changes
Formula/krb5.rb Outdated Show resolved Hide resolved
@claui
Copy link
Contributor

claui commented Jul 19, 2020

The CI failures only affect stellar-core, and are timeouts due to a long-running self test.

Both krb5 and stellar-core are security-sensitive formulae, and certainly deserve more attention than most other formulae in that respect. However, the fact that the 10.14 CI run passed is strong evidence that the timeout is not related to krb5. I think we can safely merge this.

@claui claui merged commit 694e769 into Homebrew:master Jul 19, 2020
@claui
Copy link
Contributor

claui commented Jul 19, 2020

Thanks @mistydemeo! 🍻

@mistydemeo mistydemeo deleted the fix_krb5 branch July 19, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claui claui claui approved these changes

Assignees
No one assigned
Labels
11 Big Sur is specifically affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistydemeo @claui