Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python@3.8: Update file checksum #57997

Closed
wants to merge 1 commit into from
Closed

Python@3.8: Update file checksum #57997

wants to merge 1 commit into from

Conversation

xvilo
Copy link

@xvilo xvilo commented Jul 15, 2020 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

It appears the checksum is incorrect, on Big Sur you will get a
checksum mismatch. I have checked on multiple devices:

  • MacOS: Catalina
    • curl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 > test.patch && shasum -a 256 test.patch
  • MacOS: Big Sur
    • curl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 > test.patch && shasum -a 256 test.patch
  • Linux
    • curl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 | sha256sum

This should be the 'correct' checksum. Please let me know if
I might have missed something.

Current error output when installing Make:

==> Downloading https://ftp.gnu.org/gnu/gdbm/gdbm-1.18.1.tar.gz
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/c6e5196e3cea2a139cb849d508032f117c6351da5fe84323dc13ad2a0600264a--gdbm-1.18.1.tar.gz
==> Downloading https://ftp.gnu.org/gnu/readline/readline-8.0-patches/readline80-001
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/47beb8acfca2f2c1f4c481f864e786627a8ba6e0dbdd0fc87a9d2bee461681c7--readline80-001
==> Downloading https://ftp.gnu.org/gnu/readline/readline-8.0-patches/readline80-002
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/c00dd25d193a8318f8c1387f51f4e497634b1392278fc65dbf14bb388199baef--readline80-002
==> Downloading https://ftp.gnu.org/gnu/readline/readline-8.0-patches/readline80-003
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/1c985b03f188d6b79dae2b15fbe1aa25b76a01503c2d9ccaf78900e9fdd395d9--readline80-003
==> Downloading https://ftp.gnu.org/gnu/readline/readline-8.0-patches/readline80-004
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/d362e6fd90dbb0314fa033ad3424721460f0b8b067309f035368b13d4a123399--readline80-004
==> Downloading https://ftp.gnu.org/gnu/readline/readline-8.0.tar.gz
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/2dd06cc6b778b6977a66d7986a2c0e71e557ff460a093af91f0f77a60d4e6d14--readline-8.0.tar.gz
==> Downloading https://sqlite.org/2020/sqlite-autoconf-3320300.tar.gz
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/3dfb33ca6ba2b381296328f6fadc3ebb3d5adb7e24b5ec4a853c364e71a83c99--sqlite-autoconf-3320300.tar.gz
==> Downloading https://downloads.sourceforge.net/project/lzmautils/xz-5.2.5.tar.gz
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/a13e2dce533a3dcb05b2f1b86fc45eac1f6ebf737b54ef7d3089994649d28aa8--xz-5.2.5.tar.gz
==> Downloading https://github.com/python/cpython/commit/8ea6353.patch?full_index=1
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/82c9bb8b6cab7a6728f776194a2227c013ac283127626d7809c0304ab27fbd9a--8ea6353.patch
==> Downloading https://github.com/python/cpython/pull/21114.patch?full_index=1
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/6a14c7fbcdaba9ab615bd5ce768cf84e2046a3af03897e2ad1f571c38fb6d9bb--21114.patch
==> Downloading https://github.com/python/cpython/pull/21224.patch?full_index=1
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/cdde278d542bebf8f3d16a892d039adefd1dd9c271547e04f332a533b3e46e20--21224.patch
==> Downloading https://github.com/python/cpython/pull/21249.patch?full_index=1
Already downloaded: /Users/devicelab/Library/Caches/Homebrew/downloads/dcd1b8cf834445d44c0cf485a9a947433271436d595ef04e921dbcb68c171719--21249.patch
Error: SHA256 mismatch
Expected: 11923d4a249da7b050cc2093bd9d4547dcdfbf61718b20896e8b6447e1967cb3
  Actual: 38a556795ee37561ea219d85fb03c37095fe3bc720fafbac5070211b9f698abe
 Archive: /Users/devicelab/Library/Caches/Homebrew/downloads/dcd1b8cf834445d44c0cf485a9a947433271436d595ef04e921dbcb68c171719--21249.patch
To retry an incomplete download, remove the file above.

@Bo98
Copy link
Member

Bo98 commented Jul 15, 2020

This is one of the reasons why we don't usually accept PR patches. A stable commit patch URL should be used instead.

@xvilo
Copy link
Author

xvilo commented Jul 15, 2020

@Bo98, do you want me to change this?

This was referenced Jul 15, 2020
Closed
Merged
@transip-bot @claui
python@3.8: use hosted patch for arm64 support
49eb19c 
This replaces the three unmerged PR patches with a hosted
formula patch.

This includes the following upstream pull requests:

- python/cpython#20171, "Fix _tkinter use" (prerequisite for 21249)
- python/cpython#21114, "Support arm64 in Mac/Tools/pythonw"
- python/cpython#21224, "allow python to build for macosx-11.0-arm64"
- python/cpython#21249, "ctypes fixes for arm64 Mac OS"

See also:

- Homebrew/formula-patches#292
@claui claui force-pushed the update-checksum-python branch from a5d44ee to 49eb19c Compare July 15, 2020 19:11
@claui
Copy link
Contributor

claui commented Jul 15, 2020

Thanks @xvilo. I replaced the URL with a hosted patch with the changes rolled into one file.

@xvilo
Copy link
Author

xvilo commented Jul 15, 2020 •
edited
Loading

Thanks @claui for the fast fix! Would not have done it this way ✨

@miccal
Copy link
Member

miccal commented Jul 16, 2020

Perhaps no longer required since #57934 has been merged.

@claui
Copy link
Contributor

claui commented Jul 16, 2020

@miccal Thanks. Either it’s no longer needed, or we have to redo the patch.

@Bo98
Copy link
Member

Bo98 commented Jul 16, 2020

Only one of the mentioned PRs have been merged, and I think it hasn't been backported to 3.8.

@claui
Copy link
Contributor

claui commented Jul 16, 2020

You’re correct @Bo98. I just rebased on 3.8.4 locally and tested the changes.
The patch still applies cleanly, and it all still works fine on Apple Silicon except the known tkinter issue on brew test.

@claui claui mentioned this pull request Jul 16, 2020
Closed
9 tasks
@claui
Copy link
Contributor

claui commented Jul 16, 2020 •
edited
Loading

I’ve skimmed through the 10.14 errors:

Please tick boxes where we’re ok with the failure.

@Bo98
Copy link
Member

Bo98 commented Jul 16, 2020

Since the changes here are in a block that does not even get executed on any of the CIs since none are running ARM, it should be ok to merge.

@BrewTestBot
Copy link
Member

:shipit: @claui has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claui claui claui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xvilo @Bo98 @claui @miccal @BrewTestBot @transip-bot