Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duti: add support for macOS 10.15, 10.16, 11.0 #57945

Closed
wants to merge 1 commit into from
Closed

duti: add support for macOS 10.15, 10.16, 11.0 #57945

wants to merge 1 commit into from

Conversation

claui
Copy link
Contributor

@claui claui commented Jul 14, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This adds a patch to support macOS 10.15, 10.16 (both x86_64) and 11.0 (x86_64 and arm64).

@claui claui added 10.15 Catalina is specifically affected 11 Big Sur is specifically affected labels Jul 14, 2020
Formula/duti.rb Outdated
@@ -21,6 +21,12 @@ class Duti < Formula
sha256 "0f6013b156b79aa498881f951172bcd1ceac53807c061f95c5252a8d6df2a21a"
end

# Fix compilation on macOS >= 10.15
patch do
url "https://github.com/moretension/duti/pull/43.patch?full_index=1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://github.com/moretension/duti/pull/43.patch?full_index=1"
url "https://github.com/moretension/duti/commit/4a1f54faf29af4f125134aef3a47cfe05c7755ff.patch?full_index=1"

Copy link
Contributor

@SeekingMeaning SeekingMeaning Jul 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got accidentally reverted in the latest force push

@claui
Copy link
Contributor Author

claui commented Jul 14, 2020

Related upstream PR: moretension/duti#43

@SMillerDev
Copy link
Member

This needs a revision bump

@claui
Copy link
Contributor Author

claui commented Jul 17, 2020

@SMillerDev Done.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@claui claui deleted the duti-add-macos-versions branch July 19, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.15 Catalina is specifically affected 11 Big Sur is specifically affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants