Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialog on Big Sur #57871

Closed
wants to merge 1 commit into from
Closed

Fix dialog on Big Sur #57871

wants to merge 1 commit into from

Conversation

BytesGuy
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Building dialog on Big Sur fails with:

configure: error: No curses header-files found

This PR enables the --with-ncurses configure flag to rectify this.

Builds and tests fine on both Intel and Apple Silicon - on the latter this produces a native arm64 binary

@BytesGuy BytesGuy mentioned this pull request Jul 12, 2020
Closed
9 tasks
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@claui
Copy link
Contributor

claui commented Jul 12, 2020

Thanks again @BytesGuy! 🎉

@BytesGuy
Copy link
Contributor Author

Thanks again @BytesGuy! 🎉

No problem 🙂

@BytesGuy BytesGuy deleted the dialog-macos11 branch July 12, 2020 19:56
@zdavatz
Copy link

zdavatz commented Jul 15, 2020

@claui is this commit already available via brew update?

@claui
Copy link
Contributor

claui commented Jul 15, 2020

@claui is this commit already available via brew update?

@zdavatz Yes, dialog should be fixed via brew update. Let me know if something doesn’t work for you.

@zdavatz
Copy link

zdavatz commented Jul 15, 2020

@claui I am getting the same error (configure: error: No curses header-files found) while doing: brew install lynx

@zdavatz
Copy link

zdavatz commented Jul 15, 2020

yes brew install dialog works now for me on the Apple TestKit machine.

@claui
Copy link
Contributor

claui commented Jul 15, 2020

@claui I am getting the same error (configure: error: No curses header-files found) while doing: brew install lynx

Can reproduce, am looking into it. Thanks for the pointer.

@BytesGuy
Copy link
Contributor Author

@claui I am getting the same error (configure: error: No curses header-files found) while doing: brew install lynx

Can reproduce, am looking into it. Thanks for the pointer.

@claui I have a fix for lynx and this issue, should I create a PR? Just tested it and it seems to work. Seems like there is some change with Big Sur with regards to curses, not sure why but I imagine packages that depend on ncurses will need attention

@claui
Copy link
Contributor

claui commented Jul 15, 2020

@claui I have a fix for lynx and this issue, should I create a PR?

@BytesGuy please do! We can’t have a browser monopoly on the macOS 11.0 beta 😛

@claui
Copy link
Contributor

claui commented Jul 15, 2020

@BytesGuy If it helps in any way, I managed to get rid of the unwanted superenv shim reference by setting:

ENV["PKG_CONFIG"] = Formula["openssl@1.1"].opt_lib/"pkgconfig"

@BytesGuy BytesGuy mentioned this pull request Jul 15, 2020
Merged
5 tasks
@BytesGuy
Copy link
Contributor Author

@claui I have a fix for lynx and this issue, should I create a PR?

@BytesGuy please do! We can’t have a browser monopoly on the macOS 11.0 beta 😛

😂 Yes! Here is the the PR: #58019

@zdavatz
Copy link

zdavatz commented Jul 15, 2020

@BytesGuy @claui you guys are fun! 🤙 thanks!

@claui
Copy link
Contributor

claui commented Jul 17, 2020

@zdavatz lynx has been merged, and should be working fine now.

Thanks again @BytesGuy 🍻

@zdavatz
Copy link

zdavatz commented Jul 17, 2020

@claui yes, just tested it, works great. Thank you!

@SeekingMeaning SeekingMeaning added the 11 Big Sur is specifically affected label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claui claui claui approved these changes

Assignees
No one assigned
Labels
11 Big Sur is specifically affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BytesGuy @BrewTestBot @claui @zdavatz @SeekingMeaning