Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redis: Update to support macOS 11 #57664

Merged
merged 1 commit into from
Jul 11, 2020
Merged

redis: Update to support macOS 11 #57664

merged 1 commit into from
Jul 11, 2020

Conversation

stuartcarnie
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

redis will fail on arm64 due to different ucontext_t structs, which the approved pull request to the redis project resolves

@stuartcarnie stuartcarnie mentioned this pull request Jul 8, 2020
Closed
9 tasks
@claui claui added the 11 Big Sur is specifically affected label Jul 8, 2020
claui
claui suggested changes Jul 8, 2020
View reviewed changes
Formula/redis.rb Outdated Show resolved Hide resolved
Formula/redis.rb Show resolved Hide resolved
@stuartcarnie
Copy link
Contributor Author

👋 @claui – I've pushed up your suggested feedback; thanks for the review!

SMillerDev
SMillerDev approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuartcarnie ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@SMillerDev SMillerDev requested a review from claui July 10, 2020 15:14
claui
claui approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@claui claui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set!

@claui claui merged commit 099b653 into Homebrew:master Jul 11, 2020
@jclusso
Copy link

jclusso commented Nov 20, 2020 •
edited
Loading

Does this patch resolve a separate issue from this? I'm getting this error.

Already downloaded: /Users/jarrett/Library/Caches/Homebrew/downloads/911a7607e9ed1e64aa0eb93186736f996adbe830e11164c5eecddc0e6c2d9a05--redis-6.0.9.tar.gz
==> make install PREFIX=/opt/homebrew/Cellar/redis/6.0.9 CC=clang BUILD_TLS=yes
Last 15 lines from /Users/jarrett/Library/Logs/Homebrew/redis/01.make:
  "_SSL_set_verify", referenced from:
      _connCreateAcceptedTLS in tls.o
  "_SSL_write", referenced from:
      _connTLSWrite in tls.o
      _connTLSSyncWrite in tls.o
      _redisSSLWrite in libhiredis_ssl.a(ssl.o)
  "_TLS_client_method", referenced from:
      _redisSecureConnection in libhiredis_ssl.a(ssl.o)
  "_TLS_method", referenced from:
      _tlsConfigure in tls.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [redis-server] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [install] Error 2```

@koriym
Copy link

koriym commented Nov 22, 2020

I got a same error.

@thomasdarde
Copy link

Thanks for the patch !

I have brew up to date. I'm in iTerm, launched with rosetta enabled.
brew reinstall redis -s

Redis is not able to run via launchd and this fails :
redis-server /usr/local/etc/redis.conf

It works with sudo however :
sudo redis-server /usr/local/etc/redis.conf

Also see: redis/redis#8062

@gabrielcechet
Copy link

Thanks for the patch !

I have brew up to date. I'm in iTerm, launched with rosetta enabled.
brew reinstall redis -s

Redis is not able to run via launchd and this fails :
redis-server /usr/local/etc/redis.conf

It works with sudo however :
sudo redis-server /usr/local/etc/redis.conf

Also see: redis/redis#8062

sudo redis-server /usr/local/etc/redis.conf

is it possible to put this setting on the brew automatically?

@jclusso
Copy link

jclusso commented Dec 2, 2020 via email

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@claui claui claui approved these changes

Assignees
No one assigned
Labels
11 Big Sur is specifically affected outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stuartcarnie @jclusso @koriym @thomasdarde @gabrielcechet @claui @SMillerDev @BrewTestBot