Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nettle on Apple Silicon #57455

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Fix for nettle on Apple Silicon #57455

merged 4 commits into from
Jul 20, 2020

Conversation

BytesGuy
Copy link
Contributor

@BytesGuy BytesGuy commented Jul 4, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Disabling the attempt to build with assembly optimisations which causes a failure on Apple Silicon. This is very much a temporary fix for now as it will cause some performance hit. This should get it working until arm64 support is available upstream.

@BytesGuy
Copy link
Contributor Author

BytesGuy commented Jul 4, 2020

Note: this relies on GMP being fixed by #57315

Formula/nettle.rb Outdated Show resolved Hide resolved
@claui claui added the 11 Big Sur is specifically affected label Jul 7, 2020
@BytesGuy BytesGuy changed the title Temp fix for nettle on Apple Silicon Fix for nettle on Apple Silicon Jul 17, 2020
@BytesGuy
Copy link
Contributor Author

Looks like the test failure is related to a different formula

Formula/nettle.rb Outdated Show resolved Hide resolved
Copy link
Member

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As you mentioned, the test failures are unrelated. Just one more comment and I think we're good here.

Formula/nettle.rb Outdated Show resolved Hide resolved
@mistydemeo mistydemeo merged commit a12fe9f into Homebrew:master Jul 20, 2020
@mistydemeo
Copy link
Member

Thank you! Your contribution is greatly appreciated, and the assistance getting things going on Apple Silicon is a big help.

@BytesGuy
Copy link
Contributor Author

Thank you! Your contribution is greatly appreciated, and the assistance getting things going on Apple Silicon is a big help.

Thanks :) Sorry for the late response, I have been offline for a few days!

@BytesGuy BytesGuy deleted the nettle-arm branch July 21, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Big Sur is specifically affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants