Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcre2: Only enabled JIT on x86_64 as workaround to ARM crash. #57419

Merged
merged 1 commit into from
Jul 4, 2020
Merged

pcre2: Only enabled JIT on x86_64 as workaround to ARM crash. #57419

merged 1 commit into from
Jul 4, 2020

Conversation

DodgyTim
Copy link
Contributor

@DodgyTim DodgyTim commented Jul 4, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The JIT implementation in pcre2 crashes during test on Big Sur / ARM. This change restricts the JIT functionality to x86_64 for now, allowing the formula to work successfully on ARM.

Tested on both architectures. I have filed a similar PR for pcre.

@DodgyTim DodgyTim mentioned this pull request Jul 4, 2020
Closed
9 tasks
@claui claui added the 11 Big Sur is specifically affected label Jul 4, 2020
@claui
Copy link
Contributor

claui commented Jul 4, 2020 •
edited
Loading

The 10.14 CI failure is spurious and can be ignored.

Edit: Same for 10.15 and 10.13.

Edit 2: Double-checked and confirmed that it’s just Homebrew/brew#7667 again.

claui
claui approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@claui claui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this works, and fixes brew test pcre2 on arm64.

@claui claui merged commit 3f222b4 into Homebrew:master Jul 4, 2020
@carenas
Copy link
Contributor

carenas commented Jul 10, 2020

are there any more details on that crash that could be provided to resolve zherczeg/sljit#51?

@b8591340 b8591340 mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claui claui claui approved these changes

Assignees
No one assigned
Labels
11 Big Sur is specifically affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DodgyTim @claui @carenas