Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

or-tools 9.10 #171143

Merged
merged 2 commits into from
May 15, 2024
Merged

or-tools 9.10 #171143

merged 2 commits into from
May 15, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
## Dependencies

    

  • 

    ZLIB 1.3.1.
    

    • 

  • 

    abseil-cpp 20240116.2.
    

    • 

  • 

    Protobuf v26.1.
    

    • 

  • 

    Re2 2024-04-01.
    

    • 

  • 

    HiGHS v1.7.0.
    

    • 

  • 

    Scip v900.
    

    • 

  • 

    Add support for Gurobi 11.
    

    • 



C++ Changes


    

  • replace std::vector& with absl::Span.
    • 

  • replace const std::string& with absl::string_view.
    • 

  • Improve XPRESS support.
    • 



Algorithms


    

  • more work on set covering.
    • 



CP-SAT


    

  • Improve propagation of no_overlap_2d
    • 

  • Fix crash in no_overlap_2d Large Neighborhood Search
    • 

  • Improve core based search
    • 

  • Preserve hints during presolve
    • 

  • Improve lb_tree_search
    • 

  • Improve python typing
    • 

  • Improve communication between shared_tree workers
    • 

  • Add best bound callback
    • 

  • Improve presolve (in particular lin_max)
    • 

  • Merge the linear propagator and the difference propagator
    • 

  • Change pseudo-cost implementation to be closer to the literature
    • 

  • Add missing int_mod evaluation for violation_ls and feasibility_jump
    • 



Known Issue


    

  • [bazel] Highs 1.7.0 math_opt tests failed #4203
    • 

  • [python ]MathOpt solver_test timeout on macOS #4209
    • 



Full Changelog: google/or-tools@v9.9...v9.10

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label May 8, 2024
@carlocab carlocab force-pushed the bump-or-tools-9.10 branch from dddd798 to 7ff74ae Compare May 8, 2024 10:41
@bevanjkay

This comment was marked as resolved.

Sign in to view
@bevanjkay bevanjkay force-pushed the bump-or-tools-9.10 branch from 7ff74ae to 2829774 Compare May 8, 2024 10:50
@carlocab carlocab force-pushed the bump-or-tools-9.10 branch from 2829774 to e0e8b2f Compare May 8, 2024 10:57
@carlocab carlocab requested a review from bevanjkay May 8, 2024 10:58
@carlocab
Copy link
Member

carlocab commented May 8, 2024

I considered just disabling HIGHS, but upstream include it in their builds so we should do so for ours as well, I think. Same for SCIP.

@bevanjkay
Copy link
Member

I considered just disabling HIGHS, but upstream include it in their builds so we should do so for ours as well, I think. Same for SCIP.

Yeah, it looks like they do 👍

@carlocab
Copy link
Member

carlocab commented May 8, 2024 

ld: Undefined symbols:
    Highs::setLogCallback(void (*)(HighsLogType, char const*, void*), void*), referenced from:
        operations_research::math_opt::HighsSolver::Solve(operations_research::math_opt::SolveParametersProto const&, operations_research::math_opt::ModelSolveParametersProto const&, std::__1::function<void (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&)>, operations_research::math_opt::CallbackRegistrationProto const&, std::__1::function<absl::lts_20240116::StatusOr<operations_research::math_opt::CallbackResultProto> (operations_research::math_opt::CallbackDataProto const&)>, operations_research::SolveInterrupter const*) in highs_solver.cc.o
        absl::lts_20240116::cleanup_internal::Storage<operations_research::math_opt::HighsSolver::Solve(operations_research::math_opt::SolveParametersProto const&, operations_research::math_opt::ModelSolveParametersProto const&, std::__1::function<void (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&)>, operations_research::math_opt::CallbackRegistrationProto const&, std::__1::function<absl::lts_20240116::StatusOr<operations_research::math_opt::CallbackResultProto> (operations_research::math_opt::CallbackDataProto const&)>, operations_research::SolveInterrupter const*)::$_0>::InvokeCallback() in highs_solver.cc.o
  clang: error: linker command failed with exit code 1 (use -v to see invocation)

Doesn't like our version of HIGHS, maybe.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label May 11, 2024
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers and removed stale No recent activity labels May 11, 2024
@BrewTestBot @carlocab
or-tools 9.10
0b5ff4d 
or-tools: add dependency
@carlocab carlocab force-pushed the bump-or-tools-9.10 branch from e0e8b2f to 0b5ff4d Compare May 15, 2024 04:18
@carlocab
Copy link
Member

Let's try building without HIGHS for now.

@cho-m
Copy link
Member

cho-m commented May 15, 2024

Looks like or-tools is using a deprecated HIGHS API that isn't compiled via CMake. Upstream uses a patch to enable: https://github.com/google/or-tools/blob/v9.10/patches/highs.patch

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 15, 2024
@BrewTestBot BrewTestBot enabled auto-merge May 15, 2024 18:09
@BrewTestBot BrewTestBot added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 0710397 May 15, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-or-tools-9.10 branch May 15, 2024 18:17
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@bevanjkay bevanjkay bevanjkay approved these changes

@cho-m cho-m cho-m approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrewTestBot @bevanjkay @carlocab @cho-m