Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put input parameters for MPI in a separate category #1080

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Put input parameters for MPI in a separate category #1080

merged 1 commit into from
Mar 13, 2024

Conversation

AlexanderSinn
Copy link
Member

This PR replaces

hipace.comms_buffer_on_gpu
hipace.comms_buffer_max_leading_slices
hipace.comms_buffer_max_trailing_slices

with

comms_buffer.on_gpu
comms_buffer.max_leading_slices
comms_buffer.max_trailing_slices
  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added cleaning Code cleaning, avoid duplication, better naming, better style etc. Parallelization Longitudinal and transverse MPI decomposition labels Mar 13, 2024
MaxThevenet
MaxThevenet approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@MaxThevenet MaxThevenet added the non-backward-compatible Changes the behavior of the code, old input file may give different results label Mar 13, 2024
@MaxThevenet MaxThevenet merged commit 3bb72de into Hi-PACE:development Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxThevenet MaxThevenet MaxThevenet approved these changes

Assignees
No one assigned
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc. non-backward-compatible Changes the behavior of the code, old input file may give different results Parallelization Longitudinal and transverse MPI decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSinn @MaxThevenet