Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display translatable settings only in translations UI #360 #360

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix: display translatable settings only in translations UI #360 #360

merged 4 commits into from
Nov 22, 2024

Conversation

abdou6666
Copy link
Member

@abdou6666 abdou6666 commented Nov 22, 2024 •
edited
Loading

Motivation

The issue was that some plugin settings, which are not translatable, were being returned from the backend alongside translatable ones. The fix ensures that only the translatable settings are included in the backend response for the translations UI, preventing non-translatable settings from being unnecessarily returned and displayed.

Fixes #360

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

marrouchi
marrouchi requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @abdou6666 , left some comments 👏

api/src/i18n/services/translation.service.spec.ts Outdated Show resolved Hide resolved
api/src/plugins/types.ts Outdated Show resolved Hide resolved
api/src/utils/test/fixtures/setting.ts Outdated Show resolved Hide resolved
marrouchi
marrouchi requested changes Nov 22, 2024
View reviewed changes
api/src/i18n/services/translation.service.spec.ts Outdated Show resolved Hide resolved
api/src/utils/test/fixtures/setting.ts Outdated Show resolved Hide resolved
@abdou6666 abdou6666 force-pushed the fix/api-translation-refresh branch from 765dcdc to 7d3a92e Compare November 22, 2024 14:42
@marrouchi marrouchi merged commit 485744e into main Nov 22, 2024
5 checks passed
@marrouchi marrouchi linked an issue Dec 2, 2024 that may be closed by this pull request
🐛 [BUG] - API Translation Refresh - Custom blocks settings #109
Closed
@abdou6666 abdou6666 changed the title fix: display translatable settings only in translations UI #109 fix: display translatable settings only in translations UI #360 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrouchi marrouchi marrouchi requested changes

@medchedli medchedli Awaiting requested review from medchedli

@Emnaghz Emnaghz Awaiting requested review from Emnaghz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - API Translation Refresh - Custom blocks settings
2 participants
@abdou6666 @marrouchi