Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Epic: Hide UE-related items from the user's library #4133

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Fix] Epic: Hide UE-related items from the user's library #4133

merged 1 commit into from
Nov 25, 2024

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented Nov 22, 2024 •
edited
Loading

Resolves this issue reported on Discord: https://discord.com/channels/812703221789097985/1308977164619747429

We are already checking for the namespace property being ue, but it seems this is not actually set for some UE items (specifically assets, plugins, and projects)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Nov 22, 2024
@CommandMC CommandMC self-assigned this Nov 22, 2024
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Nov 22, 2024
@CommandMC CommandMC requested review from a team, arielj, flavioislima, Nocccer and imLinguin and removed request for a team November 22, 2024 12:51
@CommandMC CommandMC changed the title [Fix] Epic: Hide UE plugins from the user's library [Fix] Epic: Hide UE-related items from the user's library Nov 22, 2024
flavioislima
flavioislima approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Etaash-mathamsetty Etaash-mathamsetty merged commit 15b25e2 into main Nov 25, 2024
9 checks passed
@Etaash-mathamsetty Etaash-mathamsetty deleted the fix/hide-ue-plugins branch November 25, 2024 03:22
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CommandMC @flavioislima @Etaash-mathamsetty