Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOG]: add support for linux native dlcs in modify install dialog #3895

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[GOG]: add support for linux native dlcs in modify install dialog #3895

merged 1 commit into from
Aug 9, 2024

Conversation

imLinguin
Copy link
Member

also automatically run post install script after completed download

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin
improv: add support for linux native dlcs in modify install dialog
ce09123 
also automatically run post install script after completed download
@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 3, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team August 3, 2024 15:52
@imLinguin imLinguin changed the title improv: add support for linux native dlcs in modify install dialog [GOG]: add support for linux native dlcs in modify install dialog Aug 3, 2024
flavioislima
flavioislima approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CommandMC
CommandMC approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have any games I could test this with, but code looks good

src/backend/storeManagers/gog/games.ts Show resolved Hide resolved
@imLinguin imLinguin linked an issue Aug 6, 2024 that may be closed by this pull request
Support GOG DLC on Linux #3894
Closed
@flavioislima flavioislima merged commit 59873b0 into main Aug 9, 2024
9 checks passed
@flavioislima flavioislima deleted the improv/linux-dlcs branch August 9, 2024 16:11
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CommandMC CommandMC CommandMC approved these changes

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GOG DLC on Linux
3 participants
@imLinguin @flavioislima @CommandMC