Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] "Wine version is not valid" clarifications #3756

Merged
merged 2 commits into from
May 17, 2024
Merged

[Fix] "Wine version is not valid" clarifications #3756

merged 2 commits into from
May 17, 2024

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 15, 2024 •
edited
Loading

Trying to launch a game with an invalid Wine version presents the user with an option to choose the default version instead, if that's valid. This is also logged in the game log, but had two issues:

  • A missing newline character caused the message to be on the same line as the next log messages (currently a Winetricks package listing)
  • We would log that we're changing the version, but wouldn't log the version that we changed to

Both of those issues are now resolved

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team May 15, 2024 20:27
@CommandMC CommandMC self-assigned this May 15, 2024
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 15, 2024
@arielj arielj merged commit 1472855 into main May 17, 2024
9 checks passed
@arielj arielj deleted the ref/wine-message-fix branch May 17, 2024 03:07
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CommandMC @arielj