Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC]: prettify discord rich presence #3743

Merged
merged 2 commits into from
May 11, 2024
Merged

[MISC]: prettify discord rich presence #3743

merged 2 commits into from
May 11, 2024

Conversation

imLinguin
Copy link
Member

@imLinguin imLinguin commented May 10, 2024 •
edited
Loading

Made a Discord RPC a bit nicer, and added a new field in GameInfo struct for providing best images for icons.
So it turns out we can give the URL instead of the key too...

Closes #3179
Closes #2869

obraz

obraz

obraz

obraz

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 10, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team May 10, 2024 09:21
@imLinguin @CommandMC
fix: simplify icon expression
4dbffc5 
Co-authored-by: Mathis Dröge <mathis.droege@ewe.net>
Etaash-mathamsetty
Etaash-mathamsetty approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imLinguin imLinguin requested a review from CommandMC May 11, 2024 12:48
@imLinguin imLinguin merged commit 5d429a1 into main May 11, 2024
9 checks passed
@imLinguin imLinguin deleted the improv/discord-rpc branch May 11, 2024 20:07
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@CommandMC CommandMC CommandMC approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discord Rich Presence shows the launcher, not the game Better Discord RPC design
3 participants
@imLinguin @CommandMC @Etaash-mathamsetty