Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add important warning about wine dependencies to readme description #3687

Conversation

makzef
Copy link
Contributor

@makzef makzef commented Apr 8, 2024

README does not provide clear description of how to install and use wine with Heroic for casual users.

When I first tried to use HGL, I faced the problem that wine installation is not working to launch games. I tried several time to reinstall HGL and different games. This led me to join the discord channel and ask for support. I found out in the topic of Frequently Asked Questions (with the help from channel members) that wine dependencies should be installed.

This simple warning in description should save time for casual users, who don't have deep knowledge of wine. Also they won't bother other people with issues that are obviously easy to fix (like in my case described above).


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Apr 8, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@flavioislima
Copy link
Member

recheck

you need to write a comment with that same phrase for it to work:
I have read the CLA Document and I hereby sign the CLA

@makzef
Copy link
Contributor Author

makzef commented Apr 8, 2024

I have read the CLA Document and I hereby sign the CLA

@makzef
Copy link
Contributor Author

makzef commented Apr 9, 2024

recheck

@CommandMC
Copy link
Collaborator

I do somewhat doubt that casual users are going to see this, but it doesn't hurt to have

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@flavioislima flavioislima merged commit 8969468 into Heroic-Games-Launcher:main Apr 26, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants