Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Formatting Changes #3542

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Small Formatting Changes #3542

merged 2 commits into from
Feb 10, 2024

Conversation

bukaj0
Copy link
Contributor

@bukaj0 bukaj0 commented Feb 9, 2024 •
edited
Loading

  1. Added Padding to the pop up window so it looks more consistent.
    Before the change:
image

After the change
image

  1. Added "spacing={1}" to cpu.tsx for consistency in logo sizes. Tested on Apple logo. Same argument can be found in gpu.tsx. The lack of this command in cpu.tsx made the logo appear just slightly bigger
    Before the change:
image

After the change
image

Use the following Checklist if you have changed something on the Backend or Frontend:

  • [yes ] Tested the feature and it's working on a current and clean install.
  • [yes ] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • [yes ] Created / Updated Tests (If necessary)
  • [yes ] Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Feb 9, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bukaj0
Copy link
Contributor Author

bukaj0 commented Feb 9, 2024

I have read the CLA Document and I hereby sign the CLA

@arielj
Copy link
Collaborator

arielj commented Feb 10, 2024

Can you show before/after screenshots? it makes it easier to understand what to look at

@bukaj0
Copy link
Contributor Author

bukaj0 commented Feb 10, 2024 •
edited
Loading

Can you show before/after screenshots? it makes it easier to understand what to look at

Hi! I meant to upload the pictures but somehow forgot :D. I Edited my pull request. Have a nice day!

arielj
arielj approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks!

@arielj arielj merged commit bda0871 into Heroic-Games-Launcher:main Feb 10, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arielj arielj arielj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bukaj0 @flavioislima @arielj