[Fix] Only download Winetricks every 7 days #3527
Conversation
CommandMC
requested review from
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
|
I'd make it even longer than 24hs, I'd pick 1 week minimum, or even 1 month. I don't think we need to be on the edge of winetricks. Most of the use cases we have are installing d3dcompiler/vcrun/etc and if a user really needs to get it updated we can instruct them to clear the cache |
|
Like... if I understand this right, between the last 2 releases of winetricks it took like 10 months |
|
We're not looking at Winetricks releases, we're looking at the master version (precisely because releases are so far apart) Bumping up the delay does sound sensible though. Are you sure clearing the cache also clears this file? |
I see, at least from a quick look at the commits it looks like once a month is enough? I see the last commit is from 2 weeks ago for example
Oh now I'm not sure, I was expecting the clear cache to clear this cache too haha... well... we can instruct the user to delete the file manually haha |
agreed, 1 week seems good |
This is done by moving the download to `utils/inet`'s `downloadFile`
CommandMC
force-pushed
the
fix/winetricks-daily
branch
from
3cf3a68 to
47b140f
Compare
Heroic as a whole doesn't really know about this file being cached, so that's currently not the case. Could of course make that a thing if this ends up being an issue, but Winetricks has also made some changes over the years so slightly-outdated versions should no longer be an issue |
CommandMC
changed the title
Before, we'd re-download Winetricks on every Heroic startup. This isn't a good idea for many reasons
utils/inet'sdownloadFilefunction already has the option to cache if the file it's pointing to is younger than X seconds, so we can just use it.Ideally we'd consolidate the two
downloadFiles into one, but they have a very different featureset & function, so that'd be a larger refactorUse the following Checklist if you have changed something on the Backend or Frontend: