Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add some copy in the Wine manager explaining what are the different Wines in linux #3456

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 21, 2024

This PR addressed a common problem that users try Wine-GE-Proton-LoL without knowing it will most likely fail if not used for League of Legends.

This can also help address common questions:

  • which wine variant is recommended (based on Glorious Eggroll's reddit posts)
  • why we allow downloading proton-ge if wine-ge is recommended
  • hopefully users understand the part about Proton-GE-Proton providing useless logs too

image
image
image

One extra note: since I had to add some style and the scss file simple enough, I moved to be a plain css file since we can now use native css nesting. We can eventually stop using sass.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 21, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 21, 2024 02:35
@arielj arielj force-pushed the wine-manager-explanations branch from cb703dd to 0666a47 Compare January 21, 2024 17:16
& svg {
margin-inline-end: 0.5rem;
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this .infoBox is the only new thing in this file, the rest is just updated indentation (I added a .wineManager wrapper selector)

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit e01bcbd into main Jan 29, 2024
9 checks passed
@arielj arielj deleted the wine-manager-explanations branch January 29, 2024 22:00
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants