Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Add support for autoinstallation of files from game folder #3448

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[UX] Add support for autoinstallation of files from game folder #3448

merged 2 commits into from
Jan 29, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 17, 2024 •
edited
Loading

This PR extends the feature that applies automatic winetricks fixes by supporting also automatic run exe in prefix actions.

Sometimes, some games include files that has to be executed that are not listed as prerequisites. The most common case is FallGuys that requires the installation of the EpicOnlineServices to solve the Missing Files error.

This can be used for any game that needs a similar tweak by adding content in the https://github.com/Heroic-Games-Launcher/known-fixes repo.

You can use Fall Guys to test this feature.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 17, 2024 03:48
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 17, 2024
flavioislima
flavioislima approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@arielj arielj merged commit f6c7ec3 into main Jan 29, 2024
9 checks passed
@arielj arielj deleted the support-known-run-exe-in-prefix branch January 29, 2024 22:01
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Etaash-mathamsetty Etaash-mathamsetty Awaiting requested review from Etaash-mathamsetty Etaash-mathamsetty was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielj @flavioislima