[Ref/Fix] Improving checkDiskSpace #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be used outside Legendary in the next commit
Doing this within Heroic allows us to use already-established patterns (dynamic import, helper functions like `genericSpawnWrapper`, validation using Zod)
This was a little overcomplicated, and lead to issues on Windows (where you don't necessarily have an existing root folder)
CommandMC
requested review from
a team,
arielj,
flavioislima,
Etaash-mathamsetty,
Nocccer and
imLinguin
and removed request for
a team
CommandMC
added
the
pr:ready-for-review
|
Just a follow-up for this one. Currently the One workaround I found in the past was to write a method that tries to write a test.txt file on the folder and returns true or false with the return. That should do it. the problem is that then we need to have two methods, but its fine. Or use only this test write file on all platforms, should work as well. |
- As Flavio mentioned, `access` doesn't seem to work on Windows, so I replaced that with some PowerShell commands that check the same thing - We have to call isWritable with the full path, as you can of course modify permissions on any folder, not just on a root directory/mount point Since this info is now always accurate, we might want to make the respective warning on the Frontend an error instead
CommandMC
force-pushed
the
ref/check-disk-space
branch
from
93f5e80 to
49fc1bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
checkDiskSpaceIPC function had a couple issues in edge-case scenarios, which could lead to Heroic freezing. Those are now resolvedTo reproduce the issue (in the current Heroic release)
It'd seem that an issue like this was also discovered on Linux by a user on our Discord (here). I can't reproduce this myself, but it might have the same root cause as the Windows issue
Use the following Checklist if you have changed something on the Backend or Frontend: