Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General repo cleanup #3420

Merged
merged 8 commits into from
Feb 3, 2024
Merged

General repo cleanup #3420

merged 8 commits into from
Feb 3, 2024

Conversation

CommandMC
Copy link
Collaborator

Some (early) spring cleaning now that the release is out of the way

These are a couple small changes mostly just focusing on readability. Functionality is not changed in any way

"-diff" only tells Git to treat the file as binary, which was not my
intention with the original change
This isn't used, since we have a proper config file (.eslintrc)
This is just for readability’s sake. I'd argue that adding/modifying
scripts happens more often than manually modifying our dependency list
This adds:
- ESLint and Prettier config
- A scope for the `src` directory
- Git commit lines being limited to 80 characters
Comments aren't valid JSON
@CommandMC CommandMC self-assigned this Jan 8, 2024
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 8, 2024
@CommandMC CommandMC requested review from a team, arielj, flavioislima, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 15, 2024 14:44
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me 👍

@CommandMC CommandMC merged commit f320fde into main Feb 3, 2024
9 checks passed
@CommandMC CommandMC deleted the general-repo-cleanup branch February 3, 2024 20:56
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants