This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Added installation step for Rosetta #22
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I thought I made a fix for this for Linux at some point, but apparently that was a fever dream. Gonna commit this as-is, but may change it to make it more generic for figuring out and fixing AVX on both Mac (which especially I would never know how to do on my own) and Linux at the same time when I get a chance. Thank you again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recent versions of GShade started shipping DLLs that require AVX by default.
When running GShade under Wine/Rosetta, AVX is not supported as M1/M2 chips can't translate the instruction, resulting in a game crash when this script is used.
I've added a step to the installer to check for when AVX support is missing under macOS and link the non-AVX DLLs instead (which is still shipped by GShade).
I tried to make as few changes as possible here to avoid introducing regressions for non-Mac systems. I unfortunately don't have a Linux machine on me but I have tested this with XIV on Mac using separate Macs with Intel/M1 CPUs and verified that the correct DLL was being linked for each.
Thanks!