Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] 리뷰 작성 UI 변경사항 작업 #99

Merged
merged 5 commits into from
Jul 16, 2022
Merged

[Design] 리뷰 작성 UI 변경사항 작업 #99

merged 5 commits into from
Jul 16, 2022

Conversation

0lynny
Copy link
Member

@0lynny 0lynny commented Jul 16, 2022

🔥 Pull requests

⛳️ 작업한 브랜치

  • 리뷰 작성 시 사진 갯수 수정
  • 리뷰 작성 시 backButton 처리

🚨 참고 사항

  • 제니가 만든 커스텀 알럿창 사용했습니다.
  • '네' 입력 후 전 화면 연결은 이후에 하겠습니다 (현재는 시스템 알럿창 띄움)

📸 스크린샷

기능 스크린샷
�BackButton처리
�리뷰 작성 취소 알림창

📟 관련 이슈

@0lynny 0lynny added Design UI 및 Layout 작업 🤖Lyn labels Jul 16, 2022
@0lynny 0lynny self-assigned this Jul 16, 2022
L-j-h-c
L-j-h-c approved these changes Jul 16, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어욤~~

HealthFoodMe/HealthFoodMe/Presentation/Detail/ReviewWriteScene/VC/ReviewWriteVC.swift
private func didTapimageAlbum() {
selectedAssets.removeAll()
userSelectedImages.removeAll()

let imagePicker = ImagePickerController()
imagePicker.settings.selection.max = 5
imagePicker.settings.selection.max = 3 - photoModel.userSelectedImages.count
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5;

👍 👍

0inn
0inn approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제니 등장 ~ ㅋㅋ 제 커스텀 창 잘 사용하셨네요 ~ 고생하셨습니다

@0lynny 0lynny merged commit 89d11a0 into Health-Food-Me:develop Jul 16, 2022
@0lynny 0lynny deleted the feature/#96 branch July 16, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@0inn 0inn 0inn approved these changes

@i-colours-u i-colours-u Awaiting requested review from i-colours-u

@yungu0010 yungu0010 Awaiting requested review from yungu0010

Assignees

@0lynny 0lynny

Labels
Design UI 및 Layout 작업 🤖Lyn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 리뷰 작성 UI 변경사항 작업
3 participants
@0lynny @0inn @L-j-h-c