Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] #47 - 검색 empty UI 구현 #50

Merged
merged 5 commits into from
Jul 13, 2022
Merged

[Design] #47 - 검색 empty UI 구현 #50

merged 5 commits into from
Jul 13, 2022

Conversation

0inn
Copy link
Contributor

@0inn 0inn commented Jul 13, 2022

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 검색 empty UI 구현
  • 검색 완료 화면 or 검색 empty 화면 flow 구현

🚨 참고 사항

  • emptyView 만들어서 hidden 처리 통해서 구현했습니다.
  • 나중에 서버 통신 통해서 isEmpty 값 설정해서 그에 맞는 화면 보이게 할 예정입니다..!
  • SearchVC 코드가 많이 길어졌는데 혹시 layout 파트 extension으로 파일 따로 뺄까요 ..?

📸 스크린샷

기능 스크린샷
검색 empty
플로우

📟 관련 이슈

@0inn 0inn added Design UI 및 Layout 작업 ☁️Jenny labels Jul 13, 2022
@0inn 0inn self-assigned this Jul 13, 2022
yungu0010
yungu0010 reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@yungu0010 yungu0010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색 플로우 진짜 복잡 그 잡채. 🌈✨정말 고생했다 언니야🌈✨

L-j-h-c
L-j-h-c approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~! 머지해주세영

0lynny
0lynny approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선배 멋지다..

yungu0010
yungu0010 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@yungu0010 yungu0010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뚝딱뚝딱 뷰공장 영인👻

@0inn 0inn merged commit 314bcea into Health-Food-Me:develop Jul 13, 2022
@0inn 0inn deleted the feature/#47 branch July 13, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@0lynny 0lynny 0lynny approved these changes

@yungu0010 yungu0010 yungu0010 approved these changes

Assignees

@0inn 0inn

Labels
Design UI 및 Layout 작업 ☁️Jenny
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 검색 empty UI 구현
4 participants
@0inn @yungu0010 @0lynny @L-j-h-c