[fix] 리뷰 탭에서 스크롤시 토글이 사라지지 않도록 인터렉션 처리 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-j-h-c
approved these changes
Sep 27, 2022
살짝 야매긴 한데, 모든 기종에서 스크롤이 될 수 있도록 최대 높이를 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
기존 리뷰 탭에서 스와이프시에, 자동으로 섹션이 붙는 원리는
scrollView가 스크롤 될 때, 이벤트 처리를 해주고 있었습니다.
그래서 블로그 리뷰와 같이 정상적으로 컨텐츠가 있을때에는 스크롤이 되어서 section이 붙었는데,
emtpyView는 height가 짧아서 스크롤이 되지 않아서 section이 붙지 않았습니다.
(이전상황)
RPReplay_Final1664293769.MP4
그래서 생각해보니까 emtpyView의 height를 늘리면 똑같이 스크롤이 먹혀서 해당 문제가 해결이 되더라구요
하하
수정한 커밋은 여기 만 체크해주시면 됩니다..
(수정사항)
RPReplay_Final1664293699.MP4
📟 관련 이슈