[Fix] #261 - 햄버거바 로그인 관련 수정 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-j-h-c
approved these changes
Sep 13, 2022
| @@ -442,7 +442,7 @@ extension HamburgerBarVC { | |||
|
|
|||
| [needLoginButton, needLoginImageButton].forEach { | |||
| $0.press { | |||
| self.presentSocialLoginAlert() | |||
| self.pushSocialLoginVC() | |||
There was a problem hiding this comment.
p3;
전달이 잘못 된 것 같은데 새로운 내비게이션 컨트롤러를 present하는 방식으로 해주세용~~! modalTransition은 crossDisolve로 하면 될 것 같습니당
There was a problem hiding this comment.
Suggested change
| self.pushSocialLoginVC() | |
| private func presentSocialLoginVC() { | |
| let loginVC = ModuleFactory.resolve().makeLoginVC() | |
| loginVC.modalTransitionStyle = .crossDissolve | |
| loginVC.modalPresentationStyle = .fullScreen | |
| self.present(loginVC, animated: true) | |
| } |
새로운 네비게이션을 present 한다는게 그냥 이런식으로 present 하는 게 맞는 걸까요 ? ?
There was a problem hiding this comment.
let rootViewController = ModuleFactory.resolve().makeSplashVC()
let navigation = UINavigationController(rootViewController: rootViewController)
navigation.modalTransitionStyle = .crossDissolve
navigation.modalPresentationStyle = .fullScreen
self.present(navigation, animated: true)UINavigationController도 ViewController의 SubClass이기 때문에 이런식으로 띄워주면 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
로그인이 필요해요 버튼 변경했습니다.
기존 로그인 알림창 나타나는 방식에서 로그인 화면으로 넘어가도록 수정했습니다.
🚨 참고 사항
navigationController push로 넘어가도록 설정했는데 화면 전환 자연스러운지 봐주세요 ~!
📸 스크린샷
default.mov
📟 관련 이슈