Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 블로그 리뷰 웹뷰로 변경 #235

Merged
merged 3 commits into from
Sep 5, 2022
Merged

[Fix] 블로그 리뷰 웹뷰로 변경 #235

merged 3 commits into from
Sep 5, 2022

Conversation

yungu0010
Copy link
Member

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 블로그 리뷰를 탭하면 웹 뷰 띄우도록 변경

🚨 참고 사항

  • 웹 뷰 상단바 title 부분의 내용은 기획에 여쭤보고 변경 예정입니다!

📸 스크린샷

기능 스크린샷
블로그 리뷰 웹 뷰

📟 관련 이슈

@yungu0010 yungu0010 added Fix 오류 해결, 코드 수정 🌈YunDol labels Aug 31, 2022
@yungu0010 yungu0010 self-assigned this Aug 31, 2022
L-j-h-c
L-j-h-c approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹뷰 후루룩~~ 고생하셨습니다! 저번에 웹뷰가 절반만 올라온다는 문제는 어떤 문제였나요?

@yungu0010
Copy link
Member Author

지난번에는 webView를 ReviewDetailVC에서 생성한 후 load했는데 webView의 상위 VC가 ReviewDetailVC여서 발생하는 문제였습니다~!
이번에는 webViewVC를 만들어서 cell을 클릭하는 함수 실행 시 webView를 루트뷰로 바꿔주는 방식으로 수정해 문제 해결했습니다😀

0lynny
0lynny approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹뷰까지 정복해버린 멋진 31기 아요 오비 ~!!

@yungu0010 yungu0010 merged commit bfa78c8 into Health-Food-Me:develop Sep 5, 2022
0lynny added a commit to 0lynny/Health-Food-Me-iOS that referenced this pull request Sep 20, 2022
@0lynny
[Chore] Health-Food-Me#235-merge
04f33bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@0lynny 0lynny 0lynny approved these changes

@i-colours-u i-colours-u Awaiting requested review from i-colours-u

@0inn 0inn Awaiting requested review from 0inn

Assignees

@yungu0010 yungu0010

Labels
Fix 오류 해결, 코드 수정 🌈YunDol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 블로그 리뷰 웹뷰로 변경
3 participants
@yungu0010 @0lynny @L-j-h-c