Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Multiply SSE #65

Merged
merged 9 commits into from
Jul 17, 2017
Merged

Matrix Multiply SSE #65

merged 9 commits into from
Jul 17, 2017

Conversation

bvisness
Copy link
Member

Just making a PR so we have a common place for discussion.

@bvisness
Copy link
Member Author

@StrangeZak I had to tweak the test compilation process so that the SSE #defines worked correctly. Everything seems to be in order now.

@strangezakary
Copy link
Member

Seems like everything i wanted to be done is done. @bvisness take a look and see if there's anything i should change.

Also, i am worried about the _MM_TRANSPOSE4_PS i added since it is a helper macro. Is it safe to assume all everyone will have this macro?

Also made the C++ tests actually run...😳
@bvisness
Copy link
Member Author

@StrangeZak I added C versions of the vector equality stuff you added.

If the SSE tests pass in clang and gcc, and it works for you in Visual Studio, then I think it's safe to assume that the macro is widely supported.

@bvisness
Copy link
Member Author

I think after this is merged and taken care of, I'm going to revisit #57 and rework our use of inline.

@strangezakary
Copy link
Member

@bvisness Looks good to me. Shall i go ahead an do the merge ?

@bvisness
Copy link
Member Author

Go for it!

@strangezakary strangezakary merged commit efd9f2f into master Jul 17, 2017
@strangezakary
Copy link
Member

Done!

@bvisness bvisness deleted the Matrix-Multiply-SSE branch July 17, 2017 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants