Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional prevent-context-menu-row prop defaulting to true #290

Merged
merged 2 commits into from
Jun 11, 2023
Merged

feat: add optional prevent-context-menu-row prop defaulting to true #290

merged 2 commits into from
Jun 11, 2023

Conversation

jxn-30
Copy link
Contributor

@jxn-30 jxn-30 commented Apr 30, 2023

This implements the feature suggested in #289

Type

What types of changes does your code introduce?

Put an x in the boxes that apply_

  • Fix
  • Feature

Checklist

Put an x in the boxes that apply._

  • Title as described
  • Add unit test by vitest if necessary

@jxn-30 jxn-30 mentioned this pull request Apr 30, 2023
Closed
MajedurRahmanMmr
MajedurRahmanMmr approved these changes May 3, 2023
View reviewed changes
Copy link

@MajedurRahmanMmr MajedurRahmanMmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MajedurRahmanMmr
Copy link

@HC200ok can you please make decesion on this.

@HC200ok HC200ok merged commit fd46782 into HC200ok:main Jun 11, 2023
@HC200ok
Copy link
Owner

HC200ok commented Jun 11, 2023

LGTM, thanks. I'm sorry for my late response.

@jxn-30 jxn-30 mentioned this pull request Jun 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MajedurRahmanMmr MajedurRahmanMmr MajedurRahmanMmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxn-30 @MajedurRahmanMmr @HC200ok