Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when container have display:flex #408

Closed
Alessandroinfo opened this issue Nov 14, 2019 · 4 comments
Closed

Issue when container have display:flex #408

Alessandroinfo opened this issue Nov 14, 2019 · 4 comments

Comments

@Alessandroinfo
Copy link

Alessandroinfo commented Nov 14, 2019 •
edited
Loading

Describe the bug
When I use simplebar inside a container flex the root of the component don't take the width of its parent I must set width: 100% to take all width.

Reproducible example
https://codesandbox.io/s/simplebar-angular-xq1yu
@Grsmto
Copy link
Owner

Grsmto commented Nov 14, 2019

Yes the Angular plugin has a container that should not be there. I fixed it but that's changing the DOM structure so will probably require at least a minor version update.
Will release soon.

@Grsmto
Copy link
Owner

Grsmto commented Nov 14, 2019

Can you test with the latest simplebar-angular@2.0.0?

@Alessandroinfo
Copy link
Author

Alessandroinfo commented Nov 15, 2019 •
edited
Loading

Yes i have updated the angular library in my project at the version 2.0.0 and i retrieve this error:
ERROR this.SimpleBar.destroy is not a function

I've also updated the reproducible example and i don't see improvements.

Grsmto added a commit that referenced this issue Nov 18, 2019
@Grsmto
fix(angular): fix typo on destroy call + add test (ref #408)
07c0e04
@Grsmto
Copy link
Owner

Grsmto commented Nov 18, 2019

@Alessandroinfo thanks for the report, it was a typo. I fixed it and added a test case for this.
It's released on simplebar-angular@2.0.1.

@Grsmto Grsmto closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Grsmto @Alessandroinfo