Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adding DOCKER_BUILD_ROOT docker arg for dev build #3241

Merged
merged 1 commit into from
Jan 25, 2024
Merged

ci: adding DOCKER_BUILD_ROOT docker arg for dev build #3241

merged 1 commit into from
Jan 25, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

as title

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@MichaelScofield MichaelScofield requested a review from zyy17 January 25, 2024 08:43
@github-actions github-actions bot added docs-not-required This change does not impact docs. size/xs labels Jan 25, 2024
zyy17
zyy17 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope it work

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 2d57bf0 Jan 25, 2024
14 checks passed
@MichaelScofield MichaelScofield deleted the MichaelScofield-patch-1 branch January 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@zyy17 zyy17 zyy17 approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelScofield @zyy17 @fengjiachun