Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install nextest bin #2990

Merged
merged 3 commits into from
Dec 25, 2023
Merged

fix: install nextest bin #2990

merged 3 commits into from
Dec 25, 2023

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Dec 25, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR changes the installation of nextest in dev-container from building from source to installing binaries directly to avoid CI failure when building nextest.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r changed the title Fix/install nextest bin fix: install nextest bin Dec 25, 2023
@v0y4g3r v0y4g3r added the docs-not-required This change does not impact docs. label Dec 25, 2023
waynexia
waynexia approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, I'm wondering if installing cargo-bininstall would fail, as it also needs SSL :rolling_on_the_floor_laughing:

docker/dev-builder/centos/Dockerfile Outdated Show resolved Hide resolved
@v0y4g3r @waynexia
Update docker/dev-builder/centos/Dockerfile
7a31bbd 
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
fengys1996
fengys1996 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Dec 25, 2023
Merged via the queue into develop with commit 4664cc6 Dec 25, 2023
11 checks passed
@evenyag evenyag deleted the fix/install-nextest-bin branch December 25, 2023 06:16
niebayes pushed a commit that referenced this pull request Dec 25, 2023
@v0y4g3r @waynexia @niebayes
fix: install nextest bin (#2990)
aca419d 
* use binstall to install nextest

* fix: change all docker files

* Update docker/dev-builder/centos/Dockerfile

Co-authored-by: Ruihang Xia <waynestxia@gmail.com>

---------

Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengys1996 fengys1996 fengys1996 approved these changes

@waynexia waynexia waynexia approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v0y4g3r @waynexia @fengys1996 @evenyag