Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: android image builder dockerfile #2541

Merged
merged 4 commits into from
Oct 9, 2023
Merged

feat: android image builder dockerfile #2541

merged 4 commits into from
Oct 9, 2023

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Oct 8, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add dockerfile for building android image.

# To build an Android binary
make build-android-bin

# (optional) Strip binary to reduce size
make strip-android-bin

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fixes #1766

@v0y4g3r v0y4g3r requested review from zyy17 and shuiyisong October 8, 2023 12:37
@codecov
Copy link

codecov bot commented Oct 8, 2023 •
edited
Loading

Codecov Report

Merging #2541 (7b5d337) into develop (17b385a) will decrease coverage by 0.40%.
Report is 6 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2541      +/-   ##
===========================================
- Coverage    85.36%   84.96%   -0.40%     
===========================================
  Files          734      737       +3     
  Lines       117347   117409      +62     
===========================================
- Hits        100175    99762     -413     
- Misses       17172    17647     +475

@shuiyisong shuiyisong requested a review from fengys1996 October 8, 2023 13:15
@v0y4g3r v0y4g3r requested a review from zyy17 October 9, 2023 08:29
zyy17
zyy17 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's have a try.

@shuiyisong shuiyisong added this pull request to the merge queue Oct 9, 2023
Merged via the queue into GreptimeTeam:develop with commit 9b3470b Oct 9, 2023
21 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@v0y4g3r @paomian
feat: android image builder dockerfile (GreptimeTeam#2541)
3bab3a4 
* feat: android image builder dockerfile

* feat: add building android dev-builder to ci config file

* fix: add build arg

* feat: use makefile to build image and add strip command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

@zyy17 zyy17 zyy17 approved these changes

@shuiyisong shuiyisong Awaiting requested review from shuiyisong

@fengys1996 fengys1996 Awaiting requested review from fengys1996

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release build for android
4 participants
@v0y4g3r @sunng87 @zyy17 @shuiyisong