Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't set the build jobs when nproc is not found #2034

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Jul 25, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Don't set the build jobs when nproc is not found;
  2. Use Makefile ifneq ($(strip $(VAR)),) to detect whether the variable is empty or not;

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17 zyy17 requested review from sunng87, evenyag and waynexia July 25, 2023 09:35
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #2034 (66732be) into develop (1f371f5) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2034      +/-   ##
===========================================
- Coverage    85.50%   84.92%   -0.58%     
===========================================
  Files          659      664       +5     
  Lines       104441   104609     +168     
===========================================
- Hits         89298    88843     -455     
- Misses       15143    15766     +623     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zyy17 zyy17 added this pull request to the merge queue Jul 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 662879f Jul 25, 2023
@zyy17 zyy17 deleted the refactor/handle-nproc-not-found branch July 25, 2023 13:53
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…eam#2034)

refactor: don't set the build jobs when nproc not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants