Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add dockerfile to build greptimedb container image #194

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 22, 2022

No description provided.

Signed-off-by: zyy17 <zyylsxm@gmail.com>
@zyy17 zyy17 requested review from evenyag, v0y4g3r and sunng87 and removed request for evenyag and v0y4g3r August 22, 2022 02:23
@codecov
Copy link

codecov bot commented Aug 22, 2022

The author of this PR, zyy17, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@zyy17 zyy17 merged commit 86dd19d into develop Aug 22, 2022
@zyy17 zyy17 deleted the build/add-dockerfile branch August 22, 2022 04:20
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
RUN cargo build --release

# Export the binary to the clean image.
# TODO(zyy17): Maybe should use the more secure container image.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now have a CentOS-based image, can we drop this TODO comment or update comments?

@zyy17 @sunng87

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an offline discussion it turns out that centos is introduced for client's requirements.

We may still be open to find a more "secure container image".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants