feat: implement alter table procedure #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
2 times, most recently
from
578db81 to
82e4b0f
Compare
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
from
82e4b0f to
4789c4c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1878 +/- ##
===========================================
- Coverage 86.03% 85.54% -0.50%
===========================================
Files 621 622 +1
Lines 99623 100100 +477
===========================================
- Hits 85715 85628 -87
- Misses 13908 14472 +564 |
fengjiachun
reviewed
Jul 5, 2023
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
3 times, most recently
from
0c1b810 to
9a95b0a
Compare
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
2 times, most recently
from
fa8a463 to
352002c
Compare
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
4 times, most recently
from
9d6abae to
2a22e2e
Compare
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
2 times, most recently
from
862444b to
6eaac5d
Compare
|
PTAL @MichaelScofield |
MichaelScofield
approved these changes
Jul 11, 2023
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
from
e4d769b to
7a652c8
Compare
|
PTAL @fengjiachun |
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
from
7a652c8 to
b321608
Compare
fengjiachun
reviewed
Jul 12, 2023
fengjiachun
approved these changes
Jul 12, 2023
WenyXu
force-pushed
the
feat/alter-table-procedure
branch
from
89cae8c to
5bb741c
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: implement alter table procedure * fix: fix uncaught error * refactor: move fetch_table/s to table_routes.rs * refactor: refactor error handling * chore: apply suggestions from CR * feat: switch to using alter table procedure * feat: add table_version * chore: apply suggestions from CR * feat: introduce ddl_channel_manager * chore: update greptime-proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
implement alter table procedure
Checklist
Refer to a related PR or issue link (optional)
#1727