chore: check catalog deregister result #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0y4g3r
changed the title
v0y4g3r
force-pushed
the
fix/check-catalog-deregister-result
branch
from
7b5bc27 to
5c7ad3a
Compare
v0y4g3r
force-pushed
the
fix/check-catalog-deregister-result
branch
from
5c7ad3a to
ee43a8d
Compare
v0y4g3r
requested review from
evenyag,
waynexia,
MichaelScofield and
killme2008
and removed request for
evenyag and
waynexia
MichaelScofield
approved these changes
Jun 21, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1810 +/- ##
===========================================
- Coverage 86.38% 86.10% -0.28%
===========================================
Files 584 584
Lines 95415 95445 +30
===========================================
- Hits 82425 82186 -239
- Misses 12990 13259 +269 |
evenyag
reviewed
Jun 21, 2023
v0y4g3r
force-pushed
the
fix/check-catalog-deregister-result
branch
from
92a2f04 to
9c33f86
Compare
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: check deregister result and return error on failure * refactor: SystemCatalog::deregister_table returns Result<()>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR adds result check when invoking
CatalogManager::deregister_table. We should remove the return value of this API in #1803 .Checklist
Refer to a related PR or issue link (optional)